Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conceal color too dark #70

Closed
ourigen opened this issue Jun 25, 2021 · 6 comments · Fixed by #293
Closed

Conceal color too dark #70

ourigen opened this issue Jun 25, 2021 · 6 comments · Fixed by #293
Labels
enhancement New feature or request

Comments

@ourigen
Copy link

ourigen commented Jun 25, 2021

Concealed math symbols in LaTeX are too dark to see.

conceal

Conceal is linked to fg_gutter so I would need to override fg_gutter which then affects a number of other elements that depend on fg_gutter. Could the default be changed to something brighter?

@folke
Copy link
Owner

folke commented Jun 25, 2021

There's probably another hl group we can change.

Can you post an example .tex file with the settings you use to show as i your example?

@folke folke closed this as completed in b15ab41 Jun 25, 2021
@folke
Copy link
Owner

folke commented Jun 25, 2021

I made it almost the same as comments now.

@ourigen
Copy link
Author

ourigen commented Jun 25, 2021

@folke Sorry for the late response

The sample .tex in the picture is

This is a test.

Inline math $\sqrt{x^2 + y^2}$

Display math

\[
	a^2 + b^2 = c^2
\]

The conceal settings are VimTeX's defaults and set conceallevel=2.

dark3 is still a little too dark I think. The concealed characters are harder to see when the formula contains many brackets as TeX syntax often have. See:

conceal_dark3

Another good contender is dark5. It's slightly brighter but fractions are more visible. fg would be even better but I'm not sure if that will affect other use cases for conceal. See dark5:

conceal_dark5

Formula in example is

$\int{(-\frac{1}{4}(e^{-4t^{2}} + e^{4t^{2}-8}))dt_{1}$

@folke folke reopened this Jun 25, 2021
@folke
Copy link
Owner

folke commented Aug 5, 2021

I'd rather not make Conceal any brighter, but like I said there's probably another HL group we can change instead.

What plugin are you using to render the latex doc?

Would be great if you could post a screenshot of running this on those characters

@folke folke added the enhancement New feature or request label Aug 5, 2021
@ourigen
Copy link
Author

ourigen commented Aug 5, 2021

@folke I'm using VimTeX to render syntax conceal.

Here is the result from running :TSHighlightCapturesUnderCursor

@folke folke closed this as completed in 8e8a11e Aug 6, 2021
@folke
Copy link
Owner

folke commented Aug 6, 2021

Apparently it's not possible to style concealed sections with different hl groups, so I updated the style of Conceal to use dark5 per your suggestion.

riley-martine pushed a commit to riley-martine/tokyonight.nvim that referenced this issue Dec 7, 2023
riley-martine pushed a commit to riley-martine/tokyonight.nvim that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants