Highlight group for EndOfBuffer

[akinsho]

Hi 👋🏾 ,

I just started customising my LspTroubleNormal background and noticed that it doesn't include the EndOfBuffer highlight so things looks like this.

The first line is the darkened highlight and the bottom is the EndOfBuffer. I think it should default link to LspTroubleNormal so it would be something like.

setlocal winhighlight=Normal:LspTroubleNormal,EndOfBuffer:LspTroubleNormal,SignColumn:LspTroubleNormal

This way a user can change the color of the full window not just part of it.

[folke]

Are you sure this is the issue here?

If I set the bg to red, the full window gets the bg color.

[folke]

You probably changed the LspTroubleText to a different bg than LspTroubleNormal?

[folke]

That's probably not it. Is it possible something else has changed the winhighlight option for the trouble window?

What does setlocal winhilight? give?

setlocal winhighlight=Normal:LspTroubleNormal should be enough.

[folke]

Nevermind. You're right. My theme doesn't set a bg for EndOfBuffer, so for me it's working.

I'll fix it. Thanks!

[folke]

it doesn't just work like that, since then the ~ at the end of buffer will get a foreground color, making it worse.

[folke]

Can fix that too with setlocal fcs=eob:\ :)

[folke]

Fixed. Can you check?

[akinsho]

@folke awesome 👍🏾 yep that's fixed it 🚀