Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mappings to lua functions directly #31

Closed
elkowar opened this issue Apr 30, 2021 · 3 comments
Closed

Create mappings to lua functions directly #31

elkowar opened this issue Apr 30, 2021 · 3 comments

Comments

@elkowar
Copy link

elkowar commented Apr 30, 2021

One thing that i'm really missing is a way to map stuff to lua functions directly, rather than going through luaeval.
Specifically, as i'm using fennel (transpile to lua), this is a big missing feature.

From what I've seen, the best way to implement this would be to store the functions that are provided in some table by ID, and then generate mappings that call that table ID.
This would be a big improvement to config and usability here ^^
@folke
Copy link
Owner

folke commented Apr 30, 2021

Great idea!

folke added a commit that referenced this issue Apr 30, 2021
@folke
feat: allow functions to be passed to create keybindings. Implements #31
cf644cd
@folke
Copy link
Owner

folke commented Apr 30, 2021

Implemented 😄

@elkowar
Copy link
Author

elkowar commented Apr 30, 2021

Nice! Thanks!

@elkowar elkowar closed this as completed Apr 30, 2021
@github-actions github-actions bot mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@folke @elkowar