feat: prefer desc to cmd as the fallback label
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use this branch since almost a week and have not faced any issues so far 🙂 I really like the idea of being able to register a description string for keybindings even without the which-key |
|
This would be very helpful for Mapx.nvim's WhichKey integration. Once this is implemented, I can remove all WhichKey specific code which would improve my plugin's performance and make the code much cleaner. |
xaviervalarino
added a commit
to xaviervalarino/dotfiles
that referenced
this pull request
Mar 29, 2022
Adds support for `vim.keymap.set` `desc` option folke/which-key.nvim#253
xaviervalarino
added a commit
to xaviervalarino/dotfiles
that referenced
this pull request
Mar 29, 2022
Adds support for `vim.keymap.set` `desc` option folke/which-key.nvim#253
|
I migrated to Lua a few days ago and I've been using this branch, since it avoids duplicate work. No problems so far. |
|
Totally makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It obviously makes more sense to use the built-in description as the default label, which even eliminates a lot of repetition of
require('which-key').register ...