Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(mappings): avoid computing error string on hot path #429

Merged
merged 1 commit into from Apr 16, 2023
Merged

perf(mappings): avoid computing error string on hot path #429

merged 1 commit into from Apr 16, 2023

Commits on Apr 7, 2023

  1. perf(mappings): avoid computing error string on hot path 

    Profiling with perfanno.nvim shows that a large portion of startup time
was spent on this line due to the computation of the error string.

This commit avoids computing the problematic error string unless it is
going to be raised.

Startup time as recorded by lazy.nvim shows a reduction of 28% with this
change: 13.43ms -> 10.49ms.
    @alaviss
    alaviss committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    0416dac View commit details
    Browse the repository at this point in the history