-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect behavior should match the HTTP specification #12
Comments
We are redirecting when the response
From your link:
What we are not taking into account is that we should probably only be redirecting for
When correcting this, it's probably advisable to include the addition of a |
Allow users to intercept and perform influence the redirection themselves. This adds a `makeRequest` option that can be used to do just that. For now, my plan is to leave it undocumented, because I want to get a release out, and don't want to commit to this API decision just yet. Specifically, I want make some progress on #19, and #12 before committing to exactly how it will behave.
This is going to be addressed eventually. See #19. |
I've started the creation of a test suite that logs the redirect behavior across browsers. |
Rather than following what browsers happen to do, let's stick to the HTTP specification, which is what browsers and servers should follow anyway. |
As far as I know, not all of the 300-399 http response codes needs to have a redirect. But looking at the code, I found you are redirecting everything in 300-399. Please look at the following url to have a reference:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
The text was updated successfully, but these errors were encountered: