Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare debug as optional using peerDependenciesMeta #141

Merged
merged 2 commits into from Aug 16, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Aug 15, 2020

Related: #135 and #140.

This will result in:

  • no change in package managers that don't support peerDependenciesMeta EDIT (Aug. 16): without peerDependencies declaration
  • no warning for undeclared peer dependency, especially in Yarn 2 with PnP

so it's completely backward compatible.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a6068cd on ylemkimon:patch-1 into b2f2ea5 on follow-redirects:master.

@RubenVerborgh RubenVerborgh self-requested a review August 16, 2020 14:15
Copy link
Collaborator

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any evidence that peerDependenciesMeta without peerDependencies works?
Because a version number is currently missing, so I don't think this can work.

@ylemkimon
Copy link
Contributor Author

@RubenVerborgh
Copy link
Collaborator

What evidence do we have that this PR works?

@ylemkimon
Copy link
Contributor Author

ylemkimon commented Aug 16, 2020

@RubenVerborgh I've setup a test repo at ylemkimon/peer-deps-meta-test. master branch installs the current version v1.13.0 and patch branch installs this PR. It is installed successfully with all 11 package managers without new warning. Note the warning is printed in master branch with Yarn 2 but not in patch branch with Yarn 2.

@RubenVerborgh
Copy link
Collaborator

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants