Call "end" after the "write" pipeline

[kettanaito]

• Fixes Do not call ".end()" in the callback of ".write" #195

[kettanaito]

Please allow me to test this version of the library before merging. While this should fix the issue I'm tackling, I need to verify that in tests.

I will post updates below.

[kettanaito]

I can confirm that this change fixes the issue by running automated tests in the reproduction repository:

 PASS  src/example.test.js
  ✓ works because post data is not defined (27 ms)

  # The next one used to fail
  ✓ does not work because there is a post data (7 ms)

🎉

[RubenVerborgh]

Perhaps swap those two lines actually?

[RubenVerborgh]

Yes, definitely need to be swapped, or we can write after end in the callback (let's add a test).

[kettanaito]

You're talking about swapping _ending and _ended right?

    this.write(data, encoding, function () {
      this._ending = true;
    });
    self._ended = true;
    currentRequest.end(null, null, callback);

This makes sense. I think I've overlooked that.

[kettanaito]

@RubenVerborgh, I've swapped the order of ending/ended state.

[kettanaito]

or we can write after end in the callback (let's add a test).

Not sure what you mean here. We can't call write in the callback of end, if that's what you're referring to. That'd throw an exception (cannot write, already ended).

[kettanaito]

Hey, @RubenVerborgh. Could you please take a look at these changes once again?

[jackromo888]

Thanks

[RubenVerborgh]

#195 has been closed, so this PR is no longer needed