Skip to content

Commit

Permalink
fix(dropdown): click-event was locked when single selection had allow…
Browse files Browse the repository at this point in the history
…Additions enabled

When a single selection dropdown allowed additions which are not available in the dropdown itself by configuring the dropdown using `allowAdditions:true` and such non-existing value was entered, it was not possible to click anywhere else in the document anymore, because the click-event was swallowed.

Reason for this was that the dropdownmenu was not active but still visible. The empty dropdown was not animated to be hidden anymore and the unbinding of the click event  (which prevented any other click event)  did not take place, keeping all following clicks for the whole document in a trap. 

Closes #591
  • Loading branch information
lubber-de authored and Sean committed Apr 5, 2019
1 parent 1a4938a commit ef3057e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/definitions/modules/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,8 @@ $.fn.dropdown = function(parameters) {
callback.call(element);
});
}
} else if( module.can.click() ) {
module.unbind.intent();
}
},

Expand Down

0 comments on commit ef3057e

Please sign in to comment.