-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal] Modal bottom margin bug on Firefox #1075
Comments
@lubber-de , Can I try to solve this issue? Anything specific I need to be aware of? |
@TomerPacific Sure, go ahead 👍 |
@lubber-de , I might be misunderstanding the issue as I am not seeing any difference. I am trying to reproduce it using the latest Firefox version and this is what I am seeing: I read the steps to reproduce several times and tried different variations to better understand the issue. The pictures above represent what I tried doing which was to go to the link and pressing the Run Code under Scrolling Modal. I also tried just scrolling all the way down on the page and didn't see any differences. Let me know how to proceed. |
🤔 I am going to reproduce using browserstack again. Maybe it was occurring on macos and Firefox only |
OK, results are here: MacOS, Chrome 77: Windows 10, Firefox 69 (and also 70 beta) Now it gets interesting: After comparing all of this, i wonder, if the slight difference is really worth the whole investigation. |
@lubber-de , so what would be your optimal solution? Do you want all browsers to have the bottom margin or not? |
@TomerPacific I think, the most optimal solution would be to have the bottom margin on every browser |
@lubber-de , Ok. I will work on making it similar for all browsers. As a side note, I am operating a Windows machine, so it will be hard for me to make sure things are working correctly for Mac. |
@lubber-de , from some investigation, I have learned that this issue does not reside within the Fomantic-UI repository, but rather the Fomantic-UI-Docs repository. Just to make sure I am on the right path, it is this file and it's associated stylesheet I should be working with. Correct? |
😨 Never thought about that...
Yes |
@lubber-de , thanks. |
@TomerPacific If it's really related to the docs repo having some breaking additional CSS there, then we should move it over to the Docs Repo, i think |
@lubber-de , do you want me to open a new issue there or are you going to move this issue over there? I have no powers here 🎩 |
@TomerPacific Moved issue from Fomantic-UI repo because it seems it's a bug in the docs rather than in FUI itself 😉 |
@lubber-de , sorry to be a hassle, but just noticed that the stylesheet that is being reference is found inside the Fomantic-UI repository. If I want to simulate my fix, how would one do so? |
@TomerPacific What stylesheet are you talking about? Everything should be available in the docs repo unless you really have to change something in the FUI repo again (but then it isn't a docs issue...) From what you were telling us, i guess the issue is because of some additional CSS which only exists in the docs? To simulate your fix, you can
|
The bug should be in FUI CSS (Since SUI flex modals I would guess) and not in the Docs CSS. We have it also inside our build application (No Docs CSS included?) and it is messing up some custom positioned stuff inside the modals depending on the browser. I do still get this bug on Windows Firefox Quantum latest version (69.0.2 64) but not with Windows latest Chrome version (77.0.3865.90). No margin on Firefox but margin on Chrome. |
Ok, i'll move this issue back to the FUI repo 🙄 😉 |
@lubber-de , after going over the modal.less file and inspecting the elements, it seems that if I add a style rule of margin-bottom, it should sort out the issue over all browsers. I wanted to ask two questions:
|
@TomerPacific You can use this jsfiddle as a base for testing https://jsfiddle.net/5d34mfgb/ |
You should use |
@lubber-de,
I have read countless SO questions and articles and some suggested using padding (which works, but does not provide the desired solution). When trying a vanilla example (without all the CSS), the rule does work, so I am afraid there is a conflicting rule(s) preventing the margin to take place. I'll try to investigate it some more. UPDATE |
@TomerPacific @jjylha |
Seems to work than you :) Just one thing. :not(.fullscreen) should probably be :not(.overlay.fullscreen)? I mean fullscreen modal needs that consistent margin too? |
Well :not(.overlay.fullscreen) doen not work. Maybe just :not(.overlay) ? |
@jjylha Good catch! Changed the PR accordingly 😉 |
Bug Report
Steps to reproduce
Expected result
Modals should have same margins on all browsers
Actual result
Firefox renders margin incorrectly
Testcase
https://fomantic-ui.com/modules/modal.html#scrolling-modal
Version
2.7.8
The text was updated successfully, but these errors were encountered: