Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Fullscreen modal stuck to left edge of page #130

Closed
ColinFrick opened this issue Sep 24, 2018 · 3 comments
Closed

[Modal] Fullscreen modal stuck to left edge of page #130

ColinFrick opened this issue Sep 24, 2018 · 3 comments
Assignees
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug

Comments

@ColinFrick
Copy link
Member

ColinFrick commented Sep 24, 2018

Original issue: Semantic-Org/Semantic-UI#6587

Steps

1. Create a fullscreen modal in html

2. Call the modal function on it and show

Expected Result

Modal should be centered

Actual Result

Modal is stuck to left edge of page

Version

2.4.0

Testcase

https://jsfiddle.net/Ljcyd5ek/

It can be fixed by adding the following css into the page to override it:

.ui.fullscreen.modal {
  left: 2.5% !important;
}
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Sep 24, 2018
@ColinFrick ColinFrick self-assigned this Sep 24, 2018
@ColinFrick ColinFrick changed the title [Modal] Fullscreen modal stuck to left edge of page [Modal] Fullscreen modal stuck to left edge of page / not working in IE11 Sep 24, 2018
@ColinFrick ColinFrick changed the title [Modal] Fullscreen modal stuck to left edge of page / not working in IE11 [Modal] Fullscreen modal stuck to left edge of page Sep 24, 2018
@lubber-de
Copy link
Member

lubber-de commented Sep 24, 2018

Even, if i personally do not care about IE11: This does not seem to fix IE11 .
See (in IE11): https://jsbin.com/semilikaqu/1/edit?html,css,js,output

It indeed fixes it for every other modern browser ;)
image

@ColinFrick
Copy link
Member Author

See #134

@lubber-de
Copy link
Member

lubber-de commented Sep 24, 2018

Sorry, missed that. i can confirm, the other fixes solves it in IE11 also now 😎

[EDIT]... unless the content of the modal does not exceed the height of the screen. i will comment details in the other issue

@y0hami y0hami closed this as completed in 3f0fe20 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants