Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toast] Action Text #160

Closed
jamessampford opened this issue Oct 8, 2018 · 3 comments
Closed

[Toast] Action Text #160

jamessampford opened this issue Oct 8, 2018 · 3 comments
Assignees
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Milestone

Comments

@jamessampford
Copy link
Contributor

Feature Request

Description

Add the option of allowing action text (like when sending/deleting an email in Gmail) to the toast prompt with a corresponding callback for when this part is specify clicked (eg. onActionClick)

An alternative could potentially allow action buttons like a MacOS notification, with primary/secondary button callbacks (eg. onButtonPrimary), however, on the other hand, buttons may not be quite suited for a toast

Example

Action Text:
https://www.howtogeek.com/wp-content/uploads/2016/12/00_lead_image_undo_send.png

Action Button(s):
https://www.jamf.com/jamf-nation/discussions/26683/macos-notification-prompts

@y0hami y0hami added type/feat Any feature requests or improvements lang/css Anything involving CSS lang/javascript Anything involving JavaScript labels Oct 8, 2018
@y0hami
Copy link
Member

y0hami commented Oct 8, 2018

I think this is a good feature to have. I would also make it have an array of actions so you could have as many as you want.

@lubber-de
Copy link
Member

Already in progress... 😉 Just get the current Toast PR #139 approved first

@lubber-de lubber-de self-assigned this Oct 15, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 2, 2018
@lubber-de lubber-de modified the milestones: 2.7.x, 2.8.x Sep 1, 2019
@lubber-de
Copy link
Member

Available by #1129

@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Oct 28, 2019
@lubber-de lubber-de modified the milestones: 2.8.x, 2.8.0 Oct 28, 2019
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Nov 13, 2019
@y0hami y0hami closed this as completed in df93795 Nov 14, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

3 participants