[Chore] Invalid CSS syntax generated by variables with no default value #1657
Labels
state/awaiting-investigation
Anything which needs more investigation
type/bug
Any issue which is a bug or PR which fixes a bug
type/discussion
Anything which is up for discussion
Description
Some variable files contain the variables with no default value, which resulted the LESS file to generate the invalid CSS syntax. Example: a variable
@searchMinWidth
with empty value would generate an invalid CSS declarationmin-width: ''
.Fomantic-UI/src/themes/default/modules/dropdown.variables
Line 222 in df26dde
Which produces an invalid CSS like:
Literally, the
min-width
declaration is not required at all, if there's no value for that. The browsers will be ignored any invalid CSS declaration, however it's still an error and violating CSS rules, and thus should be avoided.There can be several variable files which could produce this outcome and all of these variables should be reviewed and remove the corresponding CSS declarations which bound to those variables.
I proposed this for the following reasons:
The text was updated successfully, but these errors were encountered: