Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calendar] month cannot be changes using arrows using start/end calendars on endCalendar after selecting a future month on startCalendar #1851

Closed
mgrulich opened this issue Jan 21, 2021 · 1 comment · Fixed by #2000
Closed

[calendar] month cannot be changes using arrows using start/end calendars on endCalendar after selecting a future month on startCalendar #1851

mgrulich opened this issue Jan 21, 2021 · 1 comment · Fixed by #2000
Assignees
@prudho
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.9.0

Comments

@mgrulich
Copy link

Bug Report

Many times its not possible to change to month using the arrow keys of the endCalendar after selecting a date within the startCalendar. After closing end reopening the selection window of the endCalendar its possible again.

Steps to reproduce

Today is: 2021-01-21
I can reproduce it on this page: https://fomantic-ui.com/modules/calendar.html

  1. I'm refreshing the Page using [Ctrl] + [F5]
  2. I'm selecting a date in the startCalendar with a date on a future month, like 2021-03-30.
  3. This will auto open the selection window from the endCalendar.
  4. Now its many times not possible to change the month using the arrows on the top.

Expected result

Pressing the arrows should change the current displayed month

Actual result

Nothing is happen, no change of month. (Also no errors in console)

Testcase

https://jsfiddle.net/yt1n06rb/1/

Screenshot (if possible)

fomantic-ui_calendar_issue

Version

2.8.7
@mgrulich mgrulich added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Jan 21, 2021
@ko2in ko2in added lang/javascript Anything involving JavaScript and removed state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Jan 25, 2021
@lubber-de lubber-de mentioned this issue Mar 26, 2021
Closed
@prudho prudho mentioned this issue Jun 29, 2021
Merged
@prudho prudho added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation labels Jun 29, 2021
@prudho prudho self-assigned this Jun 29, 2021
@prudho prudho linked a pull request Jun 29, 2021 that will close this issue
fix(calendar): arrow keys on endCalendar when startCal has future month #2000
Merged
@lubber-de
Copy link
Member

lubber-de commented Jun 29, 2021 •
edited

Fixed by #2000
See your adjusted jsfiddle here https://jsfiddle.net/lubber/qzbg3k91/

@lubber-de lubber-de added this to the 2.9.0 milestone Jun 29, 2021
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Jul 2, 2021
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudho prudho

Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

fix(calendar): arrow keys on endCalendar when startCal has future month prudho/Fomantic-UI
4 participants
@mgrulich @ko2in @prudho @lubber-de