Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Revert "Add solve for dimmer to prevent modal scrolling in bg" #42

Merged
merged 1 commit into from Jul 4, 2018
Merged

[Modal] Revert "Add solve for dimmer to prevent modal scrolling in bg" #42

merged 1 commit into from Jul 4, 2018

Conversation

ColinFrick
Copy link
Member

The change causes a regression on all touchmove events. Removing until further investigation.

This reverts commit 75dcaa2

Reported in Semantic-Org/Semantic-UI#6449

This causes a regression on all touchmove events. Removing until further investigation.

This reverts commit 75dcaa2

Reported in Semantic-Org/Semantic-UI#6449
@ColinFrick ColinFrick added the lang/javascript Anything involving JavaScript label Jun 27, 2018
@y0hami y0hami self-requested a review June 29, 2018 11:28
@y0hami y0hami added state/awaiting-reviews Pull requests which are waiting for reviews and removed Can Merge labels Jul 4, 2018
@y0hami y0hami changed the base branch from next to beta July 4, 2018 10:05
@prudho prudho removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jul 4, 2018
@y0hami y0hami merged commit ed9500f into fomantic:beta Jul 4, 2018
@ColinFrick ColinFrick deleted the fix-6449 branch July 5, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants