Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calendar]initialDate: new Date(2019,2,1) with output "March 1, 800" #614

Closed
apple-idn opened this issue Apr 3, 2019 · 4 comments
Closed
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@apple-idn
Copy link

Bug Report

Steps to reproduce

1.iam initial date calendar
2.output year not same input

Expected result

Jepretan Layar 2019-04-04 pukul 2 45 34 AM

Actual result

Jepretan Layar 2019-04-04 pukul 2 44 35 AM

Testcase

Screenshot (when possible)

Version

2.7.4

@lubber-de
Copy link
Member

Fixed by #610
See https://jsfiddle.net/sruafp7k/1/

@lubber-de lubber-de added this to the 2.7.5 milestone Apr 3, 2019
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build labels Apr 3, 2019
@apple-idn
Copy link
Author

wow, your a man @lubber-de how can do that temporary, back to include calendar.js?

@lubber-de
Copy link
Member

The jsdelivr CDN supports to serve files out of a github branch directly. So the current dist files are still 2.7.4 but overridden by the calendar.js from the PR branch where the issue is fixed
image

@BrunoJuchli
Copy link

BrunoJuchli commented Apr 25, 2019

As another temporary workaround, until the next version is released, I believe converting the Date object to a string with .toDateString() works, too:

initialDate = myDate.toDateString()

I'm actually not a professional JS developer - I'm unsure whether this is the right conversion method overload or if it will break depending on client locale (internationalization).

@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants