Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Unexpected gap between the checkbox and other field #834

Open
ko2in opened this issue Jun 25, 2019 · 5 comments
Open

[Form] Unexpected gap between the checkbox and other field #834

ko2in opened this issue Jun 25, 2019 · 5 comments
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try type/bug Any issue which is a bug or PR which fixes a bug

Comments

@ko2in
Copy link
Member

ko2in commented Jun 25, 2019

Bug Report

The checkbox set top margin inappropriately which causes unexpected gap between the checkbox and other form fields.

Expected result

The checkbox shouldn't display too far from the other field.

Checkboxes-2

Actual result

The checkbox displays too far from the other field above. Here's the fiddle.

Checkboxes

I've tested with version 2.7.4 and older versions, but the checkbox stays too close to other field above. Here's the fiddle.

Checkboxes-3

I've a test version with some changes which produces the best output with more complex form layout. You can test in this fiddle.

I can send PR later base on this fiddle. I'm busy for my project at the moment, so, it may take longer to send my PR. If someone would like to contribute, please feel free to use my fiddle and send PR.

Version

2.7.6

@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Jul 1, 2019
@y0hami y0hami added this to the 2.7.x milestone Jul 1, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.8.x Sep 2, 2019
@lubber-de lubber-de added tag/good-first-issue Good issues for new starters to try Hacktoberfest Issues for Hacktoberfest! labels Oct 1, 2019
@Darking360
Copy link

I can work on this 🚀 I'm cloning and setting everything up 🙏

@y0hami y0hami added the state/has-pr An issue which has a related PR open label Oct 2, 2019
@lubber-de lubber-de removed the Hacktoberfest Issues for Hacktoberfest! label Oct 31, 2019
@lubber-de lubber-de removed the state/has-pr An issue which has a related PR open label Nov 14, 2020
@lubber-de lubber-de removed this from the 2.8.x milestone Nov 14, 2020
@lubber-de
Copy link
Member

@all-contributors please add @ko2in for doc, review and bug

@allcontributors
Copy link
Contributor

@lubber-de

I've put up a pull request to add @ko2in! 🎉

@amansaurabh
Copy link

Is it still open?

@lubber-de
Copy link
Member

Is it still open?

Yes, the aproached PR #1054 did not fix it (see comments there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

5 participants