Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] When in an accordion, stackable menu doesn't stack as it should with certain screen widths #921

Open
Merlin04 opened this issue Aug 5, 2019 · 3 comments
Labels
Hacktoberfest Issues for Hacktoberfest! lang/css Anything involving CSS type/feat Any feature requests or improvements

Comments

@Merlin04
Copy link

Merlin04 commented Aug 5, 2019

Bug Report

Steps to reproduce

  1. Put a stackable menu with a lot of items inside an accordion
  2. Open the accordion
  3. Try resizing the window

Expected result

The menu should stack

Actual result

It doesn't in some screen widths, it overflows off the screen

Testcase

https://jsfiddle.net/deuc3fj8/

Screenshot (when possible)

See Merlin04/webweb#11

Version

2.7.7

@maidzen
Copy link
Contributor

maidzen commented Aug 6, 2019

resize_bug

this shows the bug

@lubber-de
Copy link
Member

lubber-de commented Aug 6, 2019

That's a general issue and not related to accordion.
Currently stackable menu items only stack on mobile device with a maximum width of 767px. So it's still stacking even in an accordion, but your many menu items exceed even a tablet width

What you can only do at the moment is to adjust the @largestMobileScreen variable in menu.less to adjust it according to your needs (or use the override i provided in the jsfiddle below)

@fomantic/core Do you think we should change this from @largestMobileScreen to @largestTabletScreen ? That would fix the issue but will stack existing menus more often (breaking change)

Otherwise we should think about a general implementation of screen width dependent classes like tablet stackable, mobile only stackable

See here: https://jsfiddle.net/xbwnsto8/1/

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS labels Aug 6, 2019
@y0hami
Copy link
Member

y0hami commented Aug 27, 2019

@lubber-de I think adding the tablet & mobile stackable isn't a bad idea, we already have tablet stackable in the table component

@lubber-de lubber-de added the Hacktoberfest Issues for Hacktoberfest! label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues for Hacktoberfest! lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

4 participants