Merge tag 'v4.2.4' #56
fono09Annotations
11 errors and 4 warnings
|
lint:
app/lib/formatter.rb#L21
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
|
lint:
app/lib/formatter.rb#L22
Style/StringConcatenation: Prefer string interpolation to string concatenation. (https://rubystyle.guide#string-interpolation)
|
|
lint:
app/lib/formatter.rb#L55
[Correctable] Style/RegexpLiteral: Use %r around regular expression. (https://rubystyle.guide#percent-r)
|
|
lint:
app/lib/formatter.rb#L138
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use animate: false instead of animate = false. (https://rubystyle.guide#boolean-keyword-arguments)
|
|
lint:
app/lib/formatter.rb#L166
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
|
lint:
app/lib/formatter.rb#L212
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
|
lint:
app/lib/formatter.rb#L218
[Correctable] Style/CommentAnnotation: Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
|
|
lint:
app/lib/formatter.rb#L277
[Correctable] Style/RegexpLiteral: Use %r around regular expression. (https://rubystyle.guide#percent-r)
|
|
lint:
app/lib/formatter.rb#L279
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
|
lint:
app/lib/formatter.rb#L280
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
|
lint
Process completed with exit code 7.
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: r7kamura/rubocop-problem-matchers-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint:
app/lib/formatter.rb#L133
[Correctable] Lint/ElseLayout: Odd else layout detected. Did you mean to use elsif?
|
|
lint:
app/mailers/application_mailer.rb#L24
Lint/DuplicateMethods: Method ApplicationMailer#set_autoreply_headers! is defined at both app/mailers/application_mailer.rb:18 and app/mailers/application_mailer.rb:24.
|
|
lint:
app/models/webhook.rb#L91
Lint/DuplicateMethods: Method Webhook#validate_permissions is defined at both app/models/webhook.rb:76 and app/models/webhook.rb:91.
|