Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database in russian #15

Open
chefranov opened this issue Dec 29, 2017 · 28 comments
Open

Database in russian #15

chefranov opened this issue Dec 29, 2017 · 28 comments

Comments

@chefranov
Copy link

Hi. I have a russian fan-site of game (titanquest.org.ua). Can you to extract Database in russian and send me? I would like to add to own site. Can you help me?

@fonsleenaars
Copy link
Owner

Hey, I added a multilanguage ticket in #10. Once that's done, the data set will have a russian translation as well, I'll tag you in that ticket when it's done, that way you can see if you can use it. Otherwise the website (tq-db.net) will have a russian option as a dropdown language setting.

@chefranov
Copy link
Author

Thanks

@chefranov
Copy link
Author

If you need translate service messages into Russian language for site I can do it

@fonsleenaars
Copy link
Owner

I'll keep that in mind. I think multiple languages will be started in Febuary - maybe halfway through. If things go smoothly it might be earlier, but once I've started on it, you'll see the issue get updated :)

@chefranov
Copy link
Author

Hi. When you start improve your DB? We are waiting for new functions and improvements :)

@fonsleenaars
Copy link
Owner

Got a little busy with my real job. I'm releasing a new version next weekend and will create the new milestone with a list of issues afterwards. If multi-lingual is a priority at that point, I'll include it!

@chefranov
Copy link
Author

Thank you! Firstly I am waiting for Russian language.

@chefranov
Copy link
Author

Hello. Do you remember about this topic?) We are still waiting

@fonsleenaars
Copy link
Owner

I've begun work on this this weekend, I'll update as I go along.

@chefranov
Copy link
Author

Thank you!

@fonsleenaars
Copy link
Owner

Made a lot of progress already, testing data file with the available locales tomorrow.

I'll have to make a list of what needs to be done on the website, if there's a lot of translating there, I might ask people to submit the translations for their desired languages, but that would be very small stuff.

@fonsleenaars
Copy link
Owner

fonsleenaars commented Jun 30, 2018

So I've run the Russian locale and was wondering if you could check these for me:

This should be the shield Thornwall (https://tq-db.net/equipment/thornwall)

{
	"classification": "Epic",
	"itemLevel": 16,
	"levelRequirement": 14,
	"name": "Терновая стена",
	"properties": {
	  "augmentSkillName1": {
		"name": "+2 очка(ов) к умению Стена терновника",
		"tag": "tagSkillName068"
	  },
	  "characterLifeRegenModifier": "+15% восстановления жизни",
	  "defensiveBlock": "11% шанс блокировать 94 ед. урона",
	  "defensiveElementalResistance": "9% сопротивление силам природы",
	  "offensivePhysical": "43 ед. физического урона",
	  "retaliationPierce": "7 ~ 11 ед. ответного проникающего урона",
	  "retaliationPierceModifier": "+15% урона возвращается проникающим уроном"
	},
	"strengthRequirement": 140,
	"tag": "tagUWeapon059"
}

The affixes seem to be a bit strange, there's repeating information, is this about Russian dialects or something? This is what I see:

In english this tag would be Resistant yet I see Resistant in russian with [fs] [ms] [np] and [ns].
Would it be ok to display the name of the tag like this, or should it be different?

"tagPrefix019": {
	"equipment": "Arms (Mage), Arms (Melee), Head (Mage), Head (Melee), Chest (Mage), Chest (Melee), Amulet, Ring, Shield",
	"name": "[fs]стойкая[ms]стойкий[np]стойкие[ns]стойкое",
	"properties": [
	  {
		"defensiveCold": "40% сопротивление холоду"
	  },
	  {
		"defensiveFire": "40% сопротивление огню"
	  },
	  {
		"defensiveLightning": "40% сопротивление молниям"
	  },
	  {
		"defensiveCold": "23% сопротивление холоду",
		"defensiveFire": "23% сопротивление огню"
	  },
	  {
		"defensiveFire": "23% сопротивление огню",
		"defensiveLightning": "23% сопротивление молниям"
	  },
	  {
		"defensiveCold": "23% сопротивление холоду",
		"defensiveLightning": "23% сопротивление молниям"
	  }
	]
  }

Lastly, the skill Doom Horn, does this look correct?

"tagSkillName138": {
  "description": "Герой трубит в боевой горн, возвещая о печальной судьбе врагов, заставляя их падать духом и защищаться менее умело.",
  "name": "Горн рока",
  "properties": [
	{
	  "offensivePercentCurrentLife": "9% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "24 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "25 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "12% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "32 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "29 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "15% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "40 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "33 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "18% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "48 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "37 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "21% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "56 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "43 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "25% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "66 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "47 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "27% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "72 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "51 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "30% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "80 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "55 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "33% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "90 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "59 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	},
	{
	  "offensivePercentCurrentLife": "36% уменьшение жизни противника",
	  "offensiveSlowDefensiveReduction": "100 ед. уменьшения брони на 10.0 секунд(ы)",
	  "offensiveTotalResistanceReductionAbsolute": "65 ед. уменьшения сопротивлений",
	  "skillManaCost": "20 Energy Cost"
	}
  ],
  "tag": "tagSkillName138"
}

@chefranov
Copy link
Author

chefranov commented Jun 30, 2018

So I've run the Russian locale and was wondering if you could check these for me

Yes, it's correct!

In english this tag would be Resistant yet I see Resistant in russian with [fs] [ms] [np] and [ns].
Would it be ok to display the name of the tag like this, or should it be different?

It's a russian declencsion https://en.wikipedia.org/wiki/Russian_declension

Why this string doesn't have translate?

"skillManaCost": "20 Energy Cost"

Will be "Расход энергии 20"

If you need translate some strings for site I can help

@fonsleenaars
Copy link
Owner

fonsleenaars commented Jul 1, 2018

Thanks for checking, I'll look into the declension then!

"skillManaCost": "20 Energy Cost"

Ah good catch, a few properties were manually added because they were missing the correct format, I'll find a solution for these (there are only maybe 8 or so that are manually added).

I'll let you know if I need help translating strings for the website!

@fonsleenaars
Copy link
Owner

Hm, so is 98 Расход энергии grammatically incorrect?

If so, I might need to configure how numbers are formatted in the properties per locale. Can you send me a screenshot of a skill in the Russian locale for Titan Quest by any chance? Any item, skill, anything that has some properties on there.

@chefranov
Copy link
Author

chefranov commented Jul 4, 2018

Hm, so is 98 Расход энергии grammatically incorrect?

the number need set in the end

1
2

@fonsleenaars
Copy link
Owner

Thanks, this is super useful. I think I just learned that for all the locales, I need to introduce the correct formatting per item. This will help me make sure I'm getting it right.

I'll post some more comments here over the next few days so I'll ask you to check those for me ;)

@fonsleenaars
Copy link
Owner

Alright, I have implemented a full locale system, all languages in TQ will be available in the data now. Once the website update starts I'll message for some help with translating those texts where necessary.

@chefranov
Copy link
Author

Awesome! We will wait it

@chefranov
Copy link
Author

Hi. When will be russian language? Or maybe you can extract all items from DB in russian and if you can all images of items save separate (not a sprite) and upload on some file exchanger please. I'am going to add to my website all items, but I will it do manually.

@chefranov
Copy link
Author

chefranov commented Dec 21, 2018

Did you forgot this feature? Long time anything updates :(

@fonsleenaars
Copy link
Owner

Haven't forgotten, haven't worked on the parser in a little bit. I'll see if I can push the language update to staging this Christmas, it'll be a while before it's on the live website though.

Will update this next week.

@chefranov
Copy link
Author

I will wait

fonsleenaars added a commit that referenced this issue Dec 23, 2018
By calling the run command with the -a or -all-languages flag the
parser will iterate over all languages instead of just the specified
or default one.

Although this takes a decent amount of time, it does simplify the
task of parsing the database in all available locales.

This is in preparation of #15
@fonsleenaars
Copy link
Owner

A very early preview of the multi-lingual website is available here: https://staging.tq-db.net/

Not everything works yet, still getting a lot of things in order, just wanted to give you a quick preview. At the top right you can change languages (it will take a little while for each language to update, there is NO loader icon yet).

More updates to come these next few days

@chefranov
Copy link
Author

Cool. It looks fine! Waiting for more updates. Also you can prepare a table with translation strings for site, I will help you.

@fonsleenaars
Copy link
Owner

I will, I'm using react-intl and extract-messages-react-intl in the website implementation which results in yaml files like:

src.components.Layout.TopPanel.divine: Священный артефакт
src.components.Layout.TopPanel.epic: Эпос
src.components.Layout.TopPanel.greater: Великий артефакт
src.components.Layout.TopPanel.legendary: Легенда
src.components.Layout.TopPanel.lesser: Малый артефакт
src.components.Layout.TopPanel.mi: Редкая
src.components.Layout.TopPanel.normal: Норма
src.components.Layout.TopPanel.rare: Редкая

So I will find a way to make those available for updating to anybody willing to help translate. I've just pushed an update to staging which repairs almost all categories. I have a few more fixes to make and then I can add in the translations for the menu, etc. at which point I will make the translation files available so I'll let you know when you can help with that.

After that, I will push the update to live!

fonsleenaars added a commit that referenced this issue Jan 4, 2019
The classifications for the artifacts and formulas were not using the
locale based translations of 'Lesser', 'Greater', and 'Divine'.

Now that they are, the website is using these (on staging) to
correctly show and filter the artifacts and formulas in different
languages.

Refers #15
@fonsleenaars
Copy link
Owner

It's been deployed to tq-db.net. A few texts and labels have not been updated in the menu yet, these will be resolved in an update.

@chefranov
Copy link
Author

chefranov commented Jul 10, 2019

Hi! Are you still very busy? Now Russian version of site almost doesn't work.

  • search by Russian words doesn't work
  • some labels of site don't have Russian translate or have incorrect translate
  • json file with item's properties instead of name have word "placeholder"
    Снимок экрана 2019-07-11 в 10 35 11

And I can't still run parser on windows (see another topic).

When will you have free time for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants