Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affixes doesn't say which sort of items they are eligible for #39

Closed
DiomedesofHelos opened this issue May 21, 2018 · 57 comments
Closed

Comments

@DiomedesofHelos
Copy link

Hi.
I really love the site, but if I want a green legs armor for an example, it is hard to know which prefixes and suffixes that there's even a chance of them having. Therefore not possible for me to plan, if the prefix I want can only occur on a ring or another item that isn't legs armor.
Is it possible to update the affixes to say which kinds of green and yellow items they can occur on? Does anyone even know?
Ps. Otherwise the site is perfect, except I don't quite understand why the Adamantine Sickle of Kronos isn't there along with all the basic non-magical pieces of armor and weapons which are the ones that can have all the affixes.

@fonsleenaars
Copy link
Owner

Definitely possible, it's already reported in #6 ;) Feel free to close it yourself if #6 accurately describes what you're asking for!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented May 22, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented May 22, 2018 via email

@fonsleenaars
Copy link
Owner

Hm, hard to give an estimate at the moment, I'm trying to make time for TQDB so I'll see if I can update the release schedule to something more concrete. Maybe 3-4 weeks?

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented May 22, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Jun 4, 2018 via email

@fonsleenaars
Copy link
Owner

Thanks, I'll check if Bormo's Arm Ring is in the latest release I've been working on locally.

I think for the affix information, probably mid july by the latest? I've got 2 weeks holiday at the end of June that I plan to use to get a lot of issues worked through for this project, so the release following that holiday will probably have the affix fix in it! Wish I had more time to spend on this project, it's a lot of fun!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Jun 5, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Jul 22, 2018 via email

@fonsleenaars
Copy link
Owner

Somewhat slowly since work is busy at the moment, after this week I have another week holiday so I expect that to be the week I can finally wrap it up. Sorry for the delay!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Jul 22, 2018 via email

@fonsleenaars
Copy link
Owner

Parser changes have been completed, I'm updating the website so it can handle the new information.

Maybe 1 more week until it's done.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 5, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 14, 2018 via email

@fonsleenaars
Copy link
Owner

Oh I was looking for this issue, here's the update on staging: https://staging.tq-db.net/affix/prefixes

Once I fix a few more bugs it will go on the main website.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 14, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 14, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 14, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 14, 2018 via email

@fonsleenaars
Copy link
Owner

Of the Mammoth

Good catch thanks

only for reference

This basically means they cannot occur in-game, only if somebody were to write a mod that uses it, could they be found

requirements listed for all the Ragnarok items

I'll take a look, thanks for reporting!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 15, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 16, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 17, 2018 via email

@fonsleenaars
Copy link
Owner

No problem at all, I appreciate the bugreports, I'm just going to reopen this issue so I don't forget!

I'll respond later to the bugs, at work atm!

@fonsleenaars fonsleenaars reopened this Aug 17, 2018
@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 17, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 21, 2018 via email

@fonsleenaars
Copy link
Owner

fonsleenaars commented Aug 22, 2018

  • Of the Mammoth (this is tagged as a Prefix internally, I'll add an exception note at some point)
  • Defiled is lacking -15.00 HP regen
  • Requirements missing
  • Set display bonuses incorrectly

@fonsleenaars
Copy link
Owner

The requirements (for the MIs at least) seem to just not be set, even compared to the current tq-db.net.

I checked the files and they're not in there either. I think it might be largely in part of the MIs having affix requirements, instead of base ones. It's strange because in many instances it looks like the Normal version has a requirement but the Epic and Legendary versions don't.

Did you find any epic/legendary item without requirements? If so, link me that.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

Thanks!

Yeah that's true, I kind of need a screenshot from the current in-game for one of those examples of MIs without requirements. I think I have a high level character I can use to go do some runs to see if I can verify the in-game drop.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

Yeah, for now just add them in this ticket somewhere (you can edit your original issue if you want, up to you).

That's true, but I never trust anything except the in-game screenshots anymore, and since Ragnarok a lot of those are outdated. But you're right, sometimes it's a nice way to verify!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

Deathweaver's helmet in Epic.

Level 25
Strength 368

I think the level requirement comes from the Rugged prefix, so now all I have to do is figure out where 368 Strength comes from!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

I've found one explanation, but there's absolutely no reference to this file from the Deathweaver's helmet file, but in what seems like a generic "requirement" calculation folder, a file called

itemcost.dbr has the following equation: headStrengthEquation,50+((itemLevel-1)*7.75),

The item level for Deathweaver's Helmet is 42, so plugging that in yields:

50 + (41 * 7.75) = 367.5

Now I just need to figure out how on earth it's determined that this calculation should be used!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

So what I've done is I've set this itemcost.dbr file as a fallback for any item that doesn't have a requirement.

I did limit it to equipment, not just all things in the database. I think it works now, but I only have the Deathweaver's Helmet as definitive proof. I've deployed it to staging so you can check it.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 22, 2018 via email

@fonsleenaars
Copy link
Owner

Alrighty, I've also fixed the set item bonuses (I think, let me know if you find any errors there). It's deploying to https://staging.tq-db.net to verify.

Few more issues to close before I can move everything to the main tq-db.net website with a release note.

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 23, 2018 via email

@fonsleenaars
Copy link
Owner

No problem, I'll close this issue again, I think the issues you found have been address in the staging environment now right?

The 'of the Mammoth' will remain open for a while until I exclude it manually 😉

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 25, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 29, 2018 via email

@fonsleenaars
Copy link
Owner

Oh that's great, send me a screen shot!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 29, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 29, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 29, 2018 via email

@fonsleenaars
Copy link
Owner

Good question, I'll look into it.

I think maybe the screenshot didn't upload? I don't see any yet ;)

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 29, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Aug 30, 2018 via email

@fonsleenaars
Copy link
Owner

Thanks, I'll take a look when I've got a moment and update my findings with the parser!

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Sep 2, 2018 via email

@fonsleenaars
Copy link
Owner

Let's make a new issue with these affix bugs you've found ;)

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Sep 2, 2018 via email

@DiomedesofHelos
Copy link
Author

DiomedesofHelos commented Jun 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants