Affix bugs

[DiomedesofHelos]

As of now I have found three "impossible" regular green items:

• An "of Heroes" leg armor, even though "of Heroes" is only supposed to be found on chest armor.
• An "of the Mammoth" helm, even though "of the Mammoth" isn't even supposed to be found at all.
• An "of the Gryphon" arm armor, even though "of the Gryphon" is also not supposed to appear at all.

I've tried to send screenshots on e-mail, look for them there.

[fonsleenaars]

Thanks for reporting this in a separate issue. I don't think I've seen any e-mail with screenshots, I believe you should be able to drag and drop the screenshots in a comment, to attach them to this issue.

About the issues:
This is good news, I can use these to figure out what's going wrong with the Affix list, thanks!

[DiomedesofHelos]

Alright, hen I get home Ill try to send you the pictures as you described. I would love to know if of the mammoth is possible on MI armor and jewelry, because it's way better than of immortality which I'm planning on using so far :D

…

On Sun, 2 Sep 2018 15:03 Fons Leenaars, ***@***.***> wrote: Thanks for reporting this in a separate issue. I don't think I've seen any e-mail with screenshots, I believe you should be able to drag and drop the screenshots in a comment, to attach them to this issue. About the issues: This is good news, I can use these to figure out what's going wrong with the Affix list, thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlqwHMD1HUkUfZntjK3_9Kh6Rr2bg-eUks5uW9cKgaJpZM4WWixc> .

[DiomedesofHelos]

[DiomedesofHelos]

I just noticed something else odd. An arms armor like "Druid WRISTLET of the Gryphon" isn't supposed to even be able to have a suffix is it? Can't it only have prefixes?

[DiomedesofHelos]

Remember that the game developers are still updating the game every now and then

[fonsleenaars]

I'll need to look into that too. I'll see if I can use the Druid Wristlet as an example. It's strange because I can't even find the file for that item, but I'm sure I just need to dig a bit more.

The approach for affixes is rather tricky, most files that can have affixes have properties likes: suffixOnly, prefixOnly or prefixAndSuffix and there's chances for all of those. But instead of having to parse every single possibility and then creating an index based on what affixes apply to those items, I simply parsed the affix loot tables per item type and assigned those as possible.

Either way, it's clear I'll need to look into affixes a lot more!

[DiomedesofHelos]

I'm very much looking forward to see the answer your research will find

…

On Mon, 3 Sep 2018 16:26 Fons Leenaars, ***@***.***> wrote: I'll need to look into that too. I'll see if I can use the Druid Wristlet as an example. It's strange because I can't even find the file for that item, but I'm sure I just need to dig a bit more. The approach for affixes is rather tricky, most files that can have affixes have properties likes: suffixOnly, prefixOnly or prefixAndSuffix and there's chances for all of those. But instead of having to parse every single possibility and then creating an index based on what affixes apply to those items, I simply parsed the affix loot tables per item type and assigned those as possible. Either way, it's clear I'll need to look into affixes a lot more! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlqwHGZ9quupYGcKRxkxKM6Z3JQgs3eyks5uXTwJgaJpZM4WWixc> .

[fonsleenaars]

Alrighty, I have found your Stygian Helm of the Mammoth example, and I think this will allow me to fix the parser.

It's going to take some changes, but this should definitely help make it more accurate. I'll update this issue once I've created a fix!

[DiomedesofHelos]

Okay looking forward to see, :)

…

On Fri, 12 Oct 2018, 17:22 Fons Leenaars, ***@***.***> wrote: Alrighty, I have found your Stygian Helm of the Mammoth example, and I think this will allow me to fix the parser. It's going to take some changes, but this should definitely help make it more accurate. I'll update this issue once I've created a fix! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AlqwHKCUZ2MPur_xyzgLu1vIQoDd4-Jwks5ukLOegaJpZM4WWixc> .

[fonsleenaars]

I've pushed the fix, I'm just checking a few final things before it's pushed to production on the website.

[fonsleenaars]

Argh, have to re-open it. Almost everything is covered now, except your Dvergr Greaves revealed something.

These following two entries are from the Dvergr Greaves:

suffixRandomizerName1,records\xpack\item\lootmagicalaffixes\suffix\tablesarmor\torsomelee_e04.dbr
prefixRandomizerName1,records\xpack\item\lootmagicalaffixes\prefix\tablesarmor\torsomelee_e04.dbr,

These two lines indicate what kind of pre- and suffix can appear on the item. As you can see, they are referencing a Torso affix.

Sigh! I'll have to figure out what I'm going to do about that. If it's consistent (for example ALL greaves can have this) I'll add it, but if it's inconsistent, I'll probably end up making a separate list of special mentions.

[fonsleenaars]

I've pushed the current fix to staging and will release to production tomorrow/this weekend (https://staging.tq-db.net/).

This will at least make the affixes a lot better than before, and fix most of the issues you found. The 'of Heroes' suffix is probably not the only one that has "slight" exceptions so I'll open a separate issue for that so I can make a separate fix.

Thanks for reporting, as always!