Fix similar docs search on Julia 1.11 (#2842)

fonsp · Mar 7, 2024 · 89b5927 · 89b5927
1 parent 576ffd9
commit 89b5927
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/src/runner/PlutoRunner/src/PlutoRunner.jl b/src/runner/PlutoRunner/src/PlutoRunner.jl
@@ -2178,7 +2178,7 @@ function improve_docs!(doc_md::Markdown.MD, query::Symbol, binding::Docs.Binding
 
         perm = sortperm(suggestions_scores; rev=true)
         permute!(suggestions, perm)
-        links = map(s -> Suggestion(s, symbol), @view(suggestions[begin:min(end,DOC_SUGGESTION_LIMIT)]))
+        links = map(s -> Suggestion(string(s), symbol), Iterators.take(suggestions, DOC_SUGGESTION_LIMIT))
 
         if length(links) > 0
             push!(doc_md.content,

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -51,12 +51,3 @@ verify_no_running_processes()
 print_timeroutput()
 @timeit_include("ExpressionExplorer.jl")
 
-# TODO: test PlutoRunner functions like:
-# - from_this_notebook
-
-# TODO: test include() inside notebooks
-
-# TODO: test async execution order
-# TODO: test @bind
-
-# TODO: test if notebooks are saved correctly after edits