Skip to content

Commit

Permalink
Bugfix: Delete button not working on feedback field etc. (inputs) (#532)
Browse files Browse the repository at this point in the history
  • Loading branch information
luis-mueller committed Oct 7, 2020
1 parent 7cc235f commit ccd351e
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions frontend/components/Editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ export class Editor extends Component {
const selected = this.state.notebook.cells.filter((c) => c.selected)
if (selected.length > 0) {
this.requests.confirm_delete_multiple(verb, selected)
return true
}
}

Expand All @@ -695,15 +696,17 @@ export class Editor extends Component {
}
e.preventDefault()
} else if (e.key === "Backspace" || e.key === "Delete") {
this.delete_selected("Delete")
e.preventDefault()
if(this.delete_selected("Delete")){
e.preventDefault()
}

} else if ((e.key === "?" && has_ctrl_or_cmd_pressed(e)) || e.key === "F1") {
// On mac "cmd+shift+?" is used by chrome, so that is why this needs to be ctrl as well on mac
// Also pressing "ctrl+shift" on mac causes the key to show up as "/", this madness
// I hope we can find a better solution for this later - Dral
alert(
`Shortcuts 🎹
Shift+Enter: run cell
${ctrl_or_cmd_name}+Enter: run cell and add cell below
Delete or Backspace: delete empty cell
Expand Down

2 comments on commit ccd351e

@fonsp
Copy link
Owner

@fonsp fonsp commented on ccd351e Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/22537

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.12.0 -m "<description of version>" ccd351e66c8ffbb374fe5478658a6ee84289577a
git push origin v0.12.0

Please sign in to comment.