Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker does not support paths surrounded by double/single quote #1639

Closed
disberd opened this issue Nov 5, 2021 · 0 comments · Fixed by #1640
Closed

FilePicker does not support paths surrounded by double/single quote #1639

disberd opened this issue Nov 5, 2021 · 0 comments · Fixed by #1640

Comments

@disberd
Copy link
Contributor

disberd commented Nov 5, 2021

The autocomplete on filepicker is neat but sometime it is more convenient to directly paste in a path copied from somewhere to open a notebook.

In Windows, paths copied from shift+right-click on a file are surrounded by double quotes (they are at least for me as I have a HOME directory with a space in the middle that I can't change).

The current implementation requries me to manually delete the double quotes from the beginning and end of the path, otherwise the filename is searched with the double-quotes.

Will removing leading and trailing double or single quote from path break anything or can it be done?

disberd added a commit to disberd/Pluto.jl that referenced this issue Nov 5, 2021
Fixes fonsp#1639

Should not break existing valid names containing quotes as it only remove the trailing and leading character if there is a quote after the notebook extension
dralletje pushed a commit that referenced this issue Nov 5, 2021
* Remove trailing and leading single/double quotes from path

Fixes #1639

Should not break existing valid names containing quotes as it only remove the trailing and leading character if there is a quote after the notebook extension

* Add check to only remove if first and last characters are both equal

* shorter and prettier

* a wild console log suddendly appeared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant