Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backspace during unicode complete gives error #2388

Closed
fonsp opened this issue Nov 23, 2022 · 2 comments
Closed

Backspace during unicode complete gives error #2388

fonsp opened this issue Nov 23, 2022 · 2 comments
Labels
autocomplete <TAB> bug Something isn't working CM6 CodeMirror 6 frontend Concerning the HTML editor

Comments

@fonsp
Copy link
Owner

fonsp commented Nov 23, 2022

Schermopname.2022-11-23.om.21.09.18.mov
@fonsp fonsp added bug Something isn't working frontend Concerning the HTML editor CM6 CodeMirror 6 labels Nov 23, 2022
dralletje added a commit that referenced this issue Dec 6, 2022
@dralletje
Only do automatic autocomplete in cases where we know it is nice (Also …
617238c 
…fixes #2388 ?)
@fonsp
Copy link
Owner Author

fonsp commented Dec 13, 2022

If you attach a breakpoint to on_update_doc_query(docs_string) in update_docs_from_autocomplete_selection then you see that it fires lots of false events:

Schermopname.2022-12-13.om.14.04.50.mov

I didn't see 617238c before debugging this (can you make PRs and put separate fixes into separate PRs please).

@Pangoraw
Copy link
Collaborator

Fixed in #2526.

@fonsp fonsp added the autocomplete <TAB> label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autocomplete <TAB> bug Something isn't working CM6 CodeMirror 6 frontend Concerning the HTML editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fonsp @Pangoraw