Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not change pwd after exiting Pluto #342

Closed
Roger-luo opened this issue Sep 3, 2020 · 3 comments
Closed

do not change pwd after exiting Pluto #342

Roger-luo opened this issue Sep 3, 2020 · 3 comments
Labels
backend Concerning the julia server and runtime bug Something isn't working

Comments

@Roger-luo
Copy link
Contributor

I find currently Pluto is using cd directly instead of use it as a context.

https://github.com/fonsp/Pluto.jl/blob/master/src/evaluation/WorkspaceManager.jl#L62

this changes the results of pwd() and can cause problems when someone tries to start pluto inside a script (e.g managing pluto instances)

@fonsp
Copy link
Owner

fonsp commented Sep 3, 2020

It only cds within the notebook process, right?

@Roger-luo
Copy link
Contributor Author

for this line, I think yes. But I think this somehow affects the main process, when you

  1. execute Pluto.run
  2. then open a new notebook (don't save it)
  3. then Ctrl+C in terminal
  4. pwd() will be moved to the tempdir

Screen Shot 2020-09-03 at 12 36 23 PM

@fonsp fonsp added backend Concerning the julia server and runtime bug Something isn't working labels Sep 3, 2020
Roger-luo added a commit to Roger-luo/Pluto.jl that referenced this issue Sep 14, 2020
@Roger-luo
Copy link
Contributor Author

this should be fixed in #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants