Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CodeMirror.findModeByName instead of listing aliases #1069

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Use CodeMirror.findModeByName instead of listing aliases #1069

merged 2 commits into from
Apr 10, 2021

Conversation

schneiderfelipe
Copy link
Contributor

This implements the suggestion in a comment of #1061. Basically, all names, modes and aliases of mode/meta.js become supported for identifying languages for syntax highlighting (i.e., JavaScript is understood as javascript, ecmascript, js and node, while HTML can be either html, htmlmixed or xhtml).

The only hard-coded option now is jl, as it became available only recently on codemirror/codemirror5@bd1b7d2.

@fonsp
Copy link
Owner

fonsp commented Apr 10, 2021

Thank you!! And awesome that you contributed to CodeMirror itself.

Are you interested in working on a larger project? We have some codemirror-related projects if you are interested, like:

Also take a look at https://www.notion.so/Pluto-jl-a9982e79b7bb4c658e6216c15a9d4cab

@fonsp fonsp merged commit 0aae8fd into fonsp:main Apr 10, 2021
@schneiderfelipe schneiderfelipe deleted the codemirror-rightmode branch April 10, 2021 11:28
@schneiderfelipe
Copy link
Contributor Author

Thank you!! And awesome that you contributed to CodeMirror itself.

Are you interested in working on a larger project? We have some codemirror-related projects if you are interested, like:

* Creating a _mixed Julia mode_ that has markdown syntax highlighting inside `md"""`, and mixel html highlingting inside `@htl("""` and inside `html"""`.

* Experiment with switching to https://github.com/codemirror/codemirror.next -- one prerequisite is writing a julia mode for the new codemirror lexer. Marijn told me that he would welcome that contribution!

* Implement find-and-replace across cells in Pluto, see stalled #530

* Context-based code hints, like #279 and #420 and hopefully a general system that we can use to easily add hints in the future!

Also take a look at https://www.notion.so/Pluto-jl-a9982e79b7bb4c658e6216c15a9d4cab

Nice! I'll take a look at those!

pankgeorg pushed a commit that referenced this pull request Apr 25, 2021
* Use CodeMirror.findModeByName instead of listing aliases

* whitespace

Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants