Preserve scope of Symbol to fix #1128

[melonedo]

Replace Core.eval with Docs.Binding for Symbols
Fix #1128

[fonsp]

Thanks! Can you see if it's easy to add a test to

Pluto.jl/test/Dynamic.jl

Lines 146 to 150 in aef57ba

	@testset "Docs" begin
	@test occursin("square root", Pluto.PlutoRunner.doc_fetcher("sqrt", Main)[1])
	@test occursin("square root", Pluto.PlutoRunner.doc_fetcher("Base.sqrt", Main)[1])
	@test occursin("No documentation found", Pluto.PlutoRunner.doc_fetcher("Base.findmeta", Main)[1])
	end

? If not, let us know

You might want to create a test module to run the doc queries in:

m = Module()
Core.eval(m, quote
	"Look at me!"
	f(x) = x

	...
end)

Pluto.PlutoRunner.doc_fetcher("sqrt", m)
Pluto.PlutoRunner.doc_fetcher("f", m)
...

[melonedo]

Thanks! Can you see if it's easy to add a test to

Pluto.jl/test/Dynamic.jl

Lines 146 to 150 in aef57ba

	@testset "Docs" begin
	@test occursin("square root", Pluto.PlutoRunner.doc_fetcher("sqrt", Main)[1])
	@test occursin("square root", Pluto.PlutoRunner.doc_fetcher("Base.sqrt", Main)[1])
	@test occursin("No documentation found", Pluto.PlutoRunner.doc_fetcher("Base.findmeta", Main)[1])
	end

? If not, let us know

You might want to create a test module to run the doc queries in:

m = Module()
Core.eval(m, quote
	"Look at me!"
	f(x) = x

	...
end)

Pluto.PlutoRunner.doc_fetcher("sqrt", m)
Pluto.PlutoRunner.doc_fetcher("f", m)
...

Oh I did not notice you had instructions for local module, and I struggled on it for some time. Now I added the tests.

I also noticed the expression "m.x" is also untested, but I could not properly test it in a local module, so I marked them as broken.

[fonsp]

You can create modules inside modules:

Core.eval(m, quote
module Hello
"fun"
f(x) = x
end

end)

Core.eval(m, :(Hello.f))

[melonedo]

You can create modules inside modules:

Core.eval(m, quote
module Hello
"fun"
f(x) = x
end

end)

Core.eval(m, :(Hello.f))

julia> Core.eval(m, quote
       module Hello
       "fun"
       f(x) = x
       end

       end)
ERROR: syntax: "module" expression not at top level
Stacktrace:
 [1] top-level scope
   @ none:1
 [2] eval(m::Module, e::Any)
   @ Core .\boot.jl:360
 [3] top-level scope
   @ REPL[89]:1

This also occurs if I use it in a .jl file.

[fonsp]

Ah I see, you can't wrap it in a quote:

Core.eval(m, :(
module Hello
"fun"
f(x) = x
end

))

Core.eval(m, quote
g(x) = x
end)

Core.eval(m, :(Hello.f))

[melonedo]

Ah I see, you can't wrap it in a quote:

Core.eval(m, :(
module Hello
"fun"
f(x) = x
end

))

Core.eval(m, quote
g(x) = x
end)

Core.eval(m, :(Hello.f))

Thanks!