-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👪 Realtime collaboration #1729
base: main
Are you sure you want to change the base?
👪 Realtime collaboration #1729
Conversation
pankgeorg
commented
Dec 4, 2021
•
edited
Loading
edited
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="local-state-sync-main")
julia> using Pluto |
This comment has been minimized.
This comment has been minimized.
What is |
Yeap, should be good to go! |
Can you run this with Pluto.run(simulated_lag=1.0) and see if it works? |
@pankgeorg How ready is this? |
When you have lag and two people are typing, it is possible to get to a state when you see something different than the other client, as a 'final' state of the document, as the two states don't converge to the same 'final' for some reason. I'm not sure if this is fixable by our current approach; I'll investigate more. It works like a charm when only one party is making edits though. Update: But maybe the last update fixes that too |
This reverts commit 78cd89f.
Status: works pretty well with 7 connected clients! Had to refresh once because re-application of state failed (server was ok though) |
I thought we were only going to allow editing by one person at a time? Disabling input for others |
@pankgeorg looking at this now.. 😏 |
This is great functionality but it really should not have been in this PR... We just want to get this PR done so that we can merge it, this makes that more difficult. (Right?) @dralletje or @pankgeorg let's make a new branch for those new features and undo it on this PR? |
Grrrrr But you make a good point |