Add unique ID to <bond>
element to force re-render after bond definition
#1827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following situation, where a bond is placed inside a
DivElement
:Schermopname.2022-01-18.om.13.04.00.mov
Because the HTML contents of the bond (
<bond def=x><input type=range></bond>
) are exactly the same, Pluto's frontend will do a partial re-render of the third cell, skipping the re-render of the sliders, since those are unchanged. This means that the bond value is not set.This is a problem, because re-running a
@bond
expression will always remove the old bound value from Julia scope.This PR will guarantee that re-running
@bond
will cause the HTML element to re-render, by including a random string (generated when theBond
is created) in the HTML output.