Continue CI on error #2081
Merged
Continue CI on error #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="rh/continue-on-error")
julia> using Pluto |
rikhuijzer
added
the
tests
fonsp
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all CI test jobs get cancelled as soon as one job fails. This is very useful to save GitHub Actions minutes. However, Pluto's tests are a bit flakely which often causes all jobs to be cancelled for no good reason. Even worse, in many cases, this happens after 20 minutes. So, when the jobs are almost done anyway! Instead of getting a lot of valuable information, we now get just a bunch of "cancelled" reports.
EDIT: Got it. Other CI configs set
fail-fast: falseexplicitly. For example, https://github.com/JuliaData/DataFrames.jl/blob/main/.github/workflows/ci.yml.