-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change path to wsl path, if on wsl #2085
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/SamarthMayya/Pluto.jl", rev="fix_wsl_path")
julia> using Pluto |
resolves #763 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you:
- put this in a separate function
- use
try catch
to make sure that it never causes a crash - share a video recording of the new behaviour
Thanks!!
I don't use wsl, so is there a way I can do a video recording on linux, such that the changes are used? |
@pankgeorg can you test this on WSL and work with Samarth on finishing the PR? |
Co-authored-by: Rik Huijzer <t.h.huijzer@rug.nl>
Co-authored-by: Rik Huijzer <t.h.huijzer@rug.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@pankgeorg could you explain how these changes solve the problem of Pluto not opening when the file is open somewhere else😅 |
They don't; I replied to myself saying I'm not changing this part of the code! The code didn't work because the function wasn't invoked in the right place and didn't remove the |
@pankgeorg could you share a video recording of the functionality 😅? Thanks in advance! |
|
@pankgeorg let's merge? |
Awesome @SamarthMayya! |
@fonsp, I have followed your comments and added some changes in the
open
function.