Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path to wsl path, if on wsl #2085

Merged
merged 11 commits into from
May 9, 2022
Merged

Conversation

SamarthMayya
Copy link
Contributor

@fonsp, I have followed your comments and added some changes in the open function.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/SamarthMayya/Pluto.jl", rev="fix_wsl_path")
julia> using Pluto

@SamarthMayya
Copy link
Contributor Author

resolves #763

@SamarthMayya SamarthMayya changed the title First commit to change to wsl path Change path to wsl path, if on wsl May 2, 2022
Copy link
Owner

@fonsp fonsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you:

  • put this in a separate function
  • use try catch to make sure that it never causes a crash
  • share a video recording of the new behaviour

Thanks!!

@SamarthMayya
Copy link
Contributor Author

SamarthMayya commented May 2, 2022

Looks good! Can you:

  • put this in a separate function
  • use try catch to make sure that it never causes a crash
  • share a video recording of the new behaviour

Thanks!!

I don't use wsl, so is there a way I can do a video recording on linux, such that the changes are used?

@fonsp
Copy link
Owner

fonsp commented May 5, 2022

@pankgeorg can you test this on WSL and work with Samarth on finishing the PR?

src/notebook/PathHelpers.jl Show resolved Hide resolved
src/webserver/WebServer.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@rikhuijzer rikhuijzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SamarthMayya
Copy link
Contributor Author

@pankgeorg could you explain how these changes solve the problem of Pluto not opening when the file is open somewhere else😅

@pankgeorg
Copy link
Collaborator

@pankgeorg could you explain how these changes solve the problem of Pluto not opening when the file is open somewhere else😅

They don't; I replied to myself saying I'm not changing this part of the code! The code didn't work because the function wasn't invoked in the right place and didn't remove the \n in the end. This, plus a small reorganization is what you see in my changes!

@SamarthMayya
Copy link
Contributor Author

SamarthMayya commented May 8, 2022

Looks good! Can you:

  • put this in a separate function
  • use try catch to make sure that it never causes a crash
  • share a video recording of the new behaviour

Thanks!!

@pankgeorg could you share a video recording of the functionality 😅? Thanks in advance!

@pankgeorg
Copy link
Collaborator

Looks good! Can you:

  • put this in a separate function
  • use try catch to make sure that it never causes a crash
  • share a video recording of the new behaviour

Thanks!!

@pankgeorg could you share a video recording of the functionality 😅? Thanks in advance!

rec

@rikhuijzer
Copy link
Collaborator

@pankgeorg let's merge?

@pankgeorg pankgeorg merged commit 83b42a7 into fonsp:main May 9, 2022
@fonsp
Copy link
Owner

fonsp commented May 9, 2022

Awesome @SamarthMayya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running in Linux, but a Windows path given, try to map to Linux path and strip quote marks
4 participants