Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Julia 1.9 #2433

Merged
merged 10 commits into from
Jan 10, 2023
Merged

Test Julia 1.9 #2433

merged 10 commits into from
Jan 10, 2023

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Jan 4, 2023

This seems to be a weird issue with splatting or `union!` but I
could not manage to reproduce outside.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="test19")
julia> using Pluto

@Pangoraw Pangoraw linked an issue Jan 10, 2023 that may be closed by this pull request
@Pangoraw
Copy link
Collaborator Author

All green ✔️

@fonsp
Copy link
Owner

fonsp commented Jan 10, 2023

@fonsp fonsp merged commit 70436d9 into main Jan 10, 2023
@fonsp fonsp deleted the test19 branch January 10, 2023 19:44
@fonsp
Copy link
Owner

fonsp commented Jan 11, 2023

The tests take 50% longer to run on 1.9 🤔 cc @rikhuijzer

@rikhuijzer
Copy link
Collaborator

The tests take 50% longer to run on 1.9 thinking cc @rikhuijzer

Yes I'm very happy with Paul's work because now we can hopefully use the new package compilation better. I'm hope to find some time soon to switch Pluto.jl from PrecompileSignatures.jl to SnoopPrecompile.jl. That should probably reduce TTFX.

@greimel
Copy link
Contributor

greimel commented Jan 16, 2023

That's great! Do you plan to release this anytime soon?

@fonsp
Copy link
Owner

fonsp commented Jan 16, 2023

Yep! Rik is working on #2441 , we will release both PRs together probably. Just releasing this PR makes me worried about the 50% performance loss

@rikhuijzer
Copy link
Collaborator

The tests take 50% longer to run on 1.9 thinking cc @rikhuijzer

Likely due to a bug in Julia-1.9.0-beta2 which was fixed in Julia-1.9.0-beta3. In beta2, import Pluto took 59 seconds while it takes only 2 seconds in beta3.

@greimel
Copy link
Contributor

greimel commented Jan 19, 2023

Time for a release then?

@pankgeorg
Copy link
Collaborator

pankgeorg commented Jan 19, 2023

The tests take 50% longer to run on 1.9 thinking cc @rikhuijzer

Likely due to a bug in Julia-1.9.0-beta2 which was fixed in Julia-1.9.0-beta3. In beta2, import Pluto took 59 seconds while it takes only 2 seconds in beta3.

For the first time, I get ~80s on main. Is this with a clean cache on main? (I noticed julia is smart enough to cache precompilations through branches)

@rikhuijzer
Copy link
Collaborator

The tests take 50% longer to run on 1.9 thinking cc @rikhuijzer

Likely due to a bug in Julia-1.9.0-beta2 which was fixed in Julia-1.9.0-beta3. In beta2, import Pluto took 59 seconds while it takes only 2 seconds in beta3.

For the first time, I get ~80s on main. Is this with a clean cache on main? (I noticed julia is smart enough to cache precompilations through branches)

What do you do to get that time and which Julia version are you running?

@fonsp
Copy link
Owner

fonsp commented Jan 20, 2023

I think the number from @pankgeorg included precompilation (you get this when you run import Pluto directly after switching branches or Julia versions), which can take 80 seconds on Julia 1.9 😵‍💫

@pankgeorg
Copy link
Collaborator

Yes this is the precompilation time, without any cache.

@fonsp
Copy link
Owner

fonsp commented Jan 20, 2023

I have been discussing this @rikhuijzer , precompilation went from 15s to 60s (!) in Julia 1.9, and TTFX went from 30s to 20s. I'm a bit worried and I think we should open a Julia issue, Rik is mostly happy with the TTFX gains :)

60 seconds seems extremely long to me, that's 120 seconds on an older laptop. After seeing most other packages precompile in 3 seconds, people might assume that something is broken and restart Julia...

@greimel
Copy link
Contributor

greimel commented Jan 20, 2023

Right, but you already get the regression with the current release of Pluto on Julia 1.9 beta (in addition to Pluto bugs). Isn't releasing this already a strict improvement? The precompile time is orthogonal to the bug fixed here and can be fixed in a later release, can't it?

@fonsp
Copy link
Owner

fonsp commented Jan 20, 2023

Publishing a release is more complex than it sounds, but yes, a release is coming 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with anonymous functions in Julia 1.9
5 participants