-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Julia 1.9 #2433
Test Julia 1.9 #2433
Conversation
This seems to be a weird issue with splatting or `union!` but I could not manage to reproduce outside.
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="test19")
julia> using Pluto |
All green ✔️ |
The tests take 50% longer to run on 1.9 🤔 cc @rikhuijzer |
Yes I'm very happy with Paul's work because now we can hopefully use the new package compilation better. I'm hope to find some time soon to switch |
That's great! Do you plan to release this anytime soon? |
Yep! Rik is working on #2441 , we will release both PRs together probably. Just releasing this PR makes me worried about the 50% performance loss |
Likely due to a bug in Julia-1.9.0-beta2 which was fixed in Julia-1.9.0-beta3. In beta2, |
Time for a release then? |
For the first time, I get ~80s on |
What do you do to get that time and which Julia version are you running? |
I think the number from @pankgeorg included precompilation (you get this when you run |
Yes this is the precompilation time, without any cache. |
I have been discussing this @rikhuijzer , precompilation went from 15s to 60s (!) in Julia 1.9, and TTFX went from 30s to 20s. I'm a bit worried and I think we should open a Julia issue, Rik is mostly happy with the TTFX gains :) 60 seconds seems extremely long to me, that's 120 seconds on an older laptop. After seeing most other packages precompile in 3 seconds, people might assume that something is broken and restart Julia... |
Right, but you already get the regression with the current release of Pluto on Julia 1.9 beta (in addition to Pluto bugs). Isn't releasing this already a strict improvement? The precompile time is orthogonal to the bug fixed here and can be fixed in a later release, can't it? |
Publishing a release is more complex than it sounds, but yes, a release is coming 👍 |
This seems to be a weird issue with splatting or
union!
but Icould not manage to reproduce outside.