Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister Bonds at the start of the reactive run. #2467

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Feb 5, 2023

This moves bond element de-registration from when defining cell is run to the start of the re-defining reactive run. This prevents a bond element from being de-registered based on cell running order as occurs in #2465.

Fixes #2465.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="bond_registration")
julia> using Pluto

@Pangoraw Pangoraw marked this pull request as draft February 5, 2023 14:34
@Pangoraw Pangoraw marked this pull request as ready for review February 5, 2023 20:01
@Pangoraw Pangoraw requested a review from fonsp February 5, 2023 20:02
@Pangoraw Pangoraw changed the title De-register Bonds at the start of the reactive run. Unregister Bonds at the start of the reactive run. Feb 6, 2023
@Pangoraw Pangoraw merged commit 776cbf7 into main Feb 28, 2023
@Pangoraw Pangoraw deleted the bond_registration branch February 28, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving a @bind sometimes causes it to have the wrong value
2 participants