Restyle frontmatter dialog to match rest of pluto #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/tecosaur/Pluto.jl", rev="restyle-frontmatter-dialogue")
julia> using Pluto |
|
Thanks!! |
fonsp
reviewed
Feb 7, 2023
|
I'm busy moving these weeks, I will get back to your PRs soon! |
|
Thanks Fons, it's good to know that they're just delayed, not ignored 🙂. Oh, and I should be able to tweak this one in response to your comments this weekend. |
tecosaur
force-pushed
the
restyle-frontmatter-dialogue
branch
from
10a104b
to
61df0e3
Compare
|
While I was making the button tweaks, I realised the proportions in both mine and Fons' screenshots looked a bit off to me. I think it needs an extra 0.5em of horizontal padding, and so I'll just add that:
|
tecosaur
force-pushed
the
restyle-frontmatter-dialogue
branch
from
61df0e3
to
ea314ee
Compare
@fonsp an update on "soon" would be nice if possible 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used the frontmatter dialog, and noticed the styling didn't really fit with the rest of pluto at all. Assuming this is an oversight, I've restyled it.
Before
After