Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpressionExplorer: Handle more complex struct constructors #2525

Merged
merged 2 commits into from
Apr 10, 2023
Merged

ExpressionExplorer: Handle more complex struct constructors #2525

merged 2 commits into from
Apr 10, 2023

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Apr 9, 2023

Failing case:

# cell 1
struct A{T}
  x::T
  A(t::T) where {T} = new{T}(t)
end
# cell 2
t = A() # cycle

@Pangoraw Pangoraw added the expression explorer Figuring out assignments and references in a cell label Apr 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="struct_constructor")
julia> using Pluto

@Pangoraw Pangoraw merged commit 7a0d441 into main Apr 10, 2023
14 checks passed
@Pangoraw Pangoraw deleted the struct_constructor branch April 10, 2023 09:06
@fonsp
Copy link
Owner

fonsp commented Apr 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
expression explorer Figuring out assignments and references in a cell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pangoraw @fonsp