Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tab indexing improvements #2744

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Some tab indexing improvements #2744

merged 5 commits into from
Dec 11, 2023

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Dec 11, 2023

Improvements:

  • The "add cell" button used to appear twice in the tab order (because we secretly show two overlapping + buttons), this is now fixed
  • Changed the order of cell buttons (fold, add, run, etc) in DOM to have a more natural tab order
  • Disable (tab) autocomplete in some edge cases in static preview
  • Hide the "featured notebook back button" from accessibility tools when not visible

@fonsp fonsp added frontend Concerning the HTML editor accessibility Accessibility improvements of the frontend, like screen reader support and internationalization labels Dec 11, 2023
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="misc-accessibility-things")
julia> using Pluto

@fonsp fonsp merged commit 8d98cee into main Dec 11, 2023
3 checks passed
@fonsp fonsp deleted the misc-accessibility-things branch December 11, 2023 14:50
@fonsp fonsp added the autocomplete <TAB> label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility improvements of the frontend, like screen reader support and internationalization autocomplete <TAB> frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant