Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible button issues on touch displays #2745

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Dec 11, 2023

Before

The "add cell" buttons (+) only show around the focused cell.

image

After

The "add cell" buttons (+) always show, and have higher contrast when the cell is in focus.

image

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="touch-display-button-visibility")
julia> using Pluto

@fonsp
Copy link
Owner Author

fonsp commented Dec 11, 2023

This PR also ensures that buttons focused using Tab will be visible, even if the cell is not being hovered.

@fonsp fonsp added frontend Concerning the HTML editor accessibility Accessibility improvements of the frontend, like screen reader support and internationalization labels Dec 11, 2023
@fonsp fonsp merged commit d834f59 into main Dec 11, 2023
3 checks passed
@fonsp fonsp deleted the touch-display-button-visibility branch December 11, 2023 14:40
@fonsp fonsp mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility improvements of the frontend, like screen reader support and internationalization frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant