-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix undef showing #411
Merged
Merged
fix undef showing #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #352 |
Moelf
force-pushed
the
undef_show
branch
5 times, most recently
from
September 11, 2020 04:20
e624c7d
to
8b9566a
Compare
Nice! Could you add a testset? https://github.com/fonsp/Pluto.jl/blob/master/test/RichOutput.jl |
@fonsp done |
fonsp
requested changes
Sep 12, 2020
Can you remove abbreviations? idx, ary, els |
yes, where and why? I mean we used |
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main issue was that error happens at assign:
Pluto.jl/src/runner/PlutoRunner.jl
Line 372 in b53d282
so instead of broadcast over
zip
of (index, elements), a specialized function for array is implemented.Also, I think a lot can be re-used from
Base
, for example:Maybe for the next re-factor 馃懛
Also I switched to
@view
when possible, since users can have huge array (maybe each element is big or something), so slicing with copy was not as good of an idea (I think).After this patch: