Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undef showing #411

Merged
merged 4 commits into from
Sep 12, 2020
Merged

fix undef showing #411

merged 4 commits into from
Sep 12, 2020

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Sep 11, 2020

main issue was that error happens at assign:

i, el = pair

so instead of broadcast over zip of (index, elements), a specialized function for array is implemented.

Also, I think a lot can be re-used from Base, for example:

julia> Base.print_matrix(stdout, vvv)
 #undef
 #undef
 #undef

Maybe for the next re-factor 馃懛

Also I switched to @view when possible, since users can have huge array (maybe each element is big or something), so slicing with copy was not as good of an idea (I think).

After this patch:
image

@Moelf
Copy link
Contributor Author

Moelf commented Sep 11, 2020

fix #352

@Moelf Moelf force-pushed the undef_show branch 5 times, most recently from e624c7d to 8b9566a Compare September 11, 2020 04:20
@fonsp
Copy link
Owner

fonsp commented Sep 11, 2020

Nice! Could you add a testset?

https://github.com/fonsp/Pluto.jl/blob/master/test/RichOutput.jl

@Moelf
Copy link
Contributor Author

Moelf commented Sep 11, 2020

@fonsp done

src/runner/PlutoRunner.jl Outdated Show resolved Hide resolved
src/runner/PlutoRunner.jl Outdated Show resolved Hide resolved
@fonsp
Copy link
Owner

fonsp commented Sep 12, 2020

Can you remove abbreviations? idx, ary, els

@Moelf
Copy link
Contributor Author

Moelf commented Sep 12, 2020

Can you remove abbreviations? idx, ary, els

yes, where and why? I mean we used i, el = pair before without a problem right?

@fonsp
Copy link
Owner

fonsp commented Sep 12, 2020

Awesome, thanks!

@fonsp fonsp merged commit 5c3cc9e into fonsp:master Sep 12, 2020
@Moelf Moelf deleted the undef_show branch September 12, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants