Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'undefineds' time unit for long running cells #442

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

isofew
Copy link
Contributor

@isofew isofew commented Sep 16, 2020

Hi, I found that when a cell runs for more than 1000 seconds, the displayed time unit will become 'undefineds'. (See the following screenshot)

image

It seems to be due to an index error in frontend/components/RunArea.js I fixed the loop index bound so it won't further increase when already at the largest time unit (seconds)

To avoid 'undefineds' time unit when the cell runs for more than 1000 seconds.
@fonsp
Copy link
Owner

fonsp commented Sep 16, 2020

Yay! Thank you for debugging and fixing this yourself! I guess it was trying show 1.2 kilosecond :)

And cool to hear that you are doing long running computations with Pluto! Maybe you would like to comment on your experience here? #116 or #229

@fonsp fonsp merged commit 1878775 into fonsp:master Sep 16, 2020
@isofew
Copy link
Contributor Author

isofew commented Sep 16, 2020

Yay! Thank you for debugging and fixing this yourself! I guess it was trying show 1.2 kilosecond :)

And cool to hear that you are doing long running computations with Pluto! Maybe you would like to comment on your experience here? #116 or #229

Thanks for the reference, I'll check out the threads and see how can I contribute there.

By the way I also noticed another bug related to long running cells: when the cell finished, the bar on its left is still in a running state and the time measurement won't display. I know it's finished because all dependent cells returned and I can interact normally, see example below:

Screenshot 2020-09-16 at 18 58 29

Do you have some idea what the problem might be?

@fonsp
Copy link
Owner

fonsp commented Sep 16, 2020

Is this after your fix?

@isofew
Copy link
Contributor Author

isofew commented Sep 16, 2020

Is this after your fix?

No it's before the fix.

Ah it's most likely a connection issue, I saw this error message in the terminal:

_ Warning: Reading WebSocket client stream failed for unknown reason:
_   exception =
_    KeyError: key Symbol("1ndjz3w") not found
_    Stacktrace:
_     [1] getindex at ./dict.jl:467 [inlined]
_     [2] putclientupdates! at /home/zhixing/julia/depot/packages/Pluto/upwxH/src/webserver/PutUpdates.jl:59 [inlined]
...

So during the many minutes of running, my browser briefly disconnected with the server (that's not running locally) with the message gone missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants