Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔆 Fancy JS animation magic support #582

Merged
merged 10 commits into from
Oct 20, 2020
Merged

🔆 Fancy JS animation magic support #582

merged 10 commits into from
Oct 20, 2020

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Oct 17, 2020

The important commits in this PR are:

c9b8638 (#582) (allows <script> return DOM.svg(200,200) </script>)

9001531 (#582) (fixes scrolling issue with <script> return DOM.svg(200,200) </script> and #535)

3904b60 (#582)

b7cb6b2 (#582)

@fonsp fonsp linked an issue Oct 17, 2020 that may be closed by this pull request
@fonsp
Copy link
Owner Author

fonsp commented Oct 17, 2020

This demonstrates why this is needed (without comments hehehehhe)
https://gist.github.com/fonsp/1aa721b6b346697a21ae064d28ab9e76

@fonsp
Copy link
Owner Author

fonsp commented Oct 17, 2020

d3_state

@fonsp fonsp marked this pull request as ready for review October 19, 2020 13:05
@fonsp
Copy link
Owner Author

fonsp commented Oct 19, 2020

The only thing I'd still like to add is that this should only contain the previous value if the cell ran as a reactive response, not because you edited the cell and ran it. (Just like obs)

When working on these viz I constantly changed the script ID to some new gibberish to prevent the behaviour.

@fonsp fonsp changed the title 🔆 More js changes 🔆 Fancy JS animation magic support Oct 20, 2020
@fonsp fonsp merged commit 6a8d495 into master Oct 20, 2020
@fonsp fonsp deleted the more-js-changes branch October 20, 2020 18:38
@fonsp
Copy link
Owner Author

fonsp commented Oct 22, 2020

ode_superinteractive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a variable interpolated into a MathJax equation scrolls notebook
1 participant