Prevent leaking the secret to cross origins #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents leaking the secrets stored in the url query parameter to third party servers. The header instructs browsers to send only the origin part of the url as referrer on cross origin requests.
|
Thanks! Let us know if you find anything else :) We will probably solve 241 by 'scraping' for asset URLs and bundling those into a Julia artifact. The frontend service worker will then use the Pluto backend as a cache (I think). |
|
I changed this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the secret is exposed to third parties (CDN , Google) through the referrer sent for the linked asset requests. "Referrer : http://pluto-server:1234/?secret=XXXX"
This is a quick-fix proposal to set a Referrer-Policy on each http request. The header instructs browsers to send only the origin part of the url as referrer on cross origin requests.
For a better fix (and better offline support #241 ) i would suggest removing the external dependencies altogether. This could either be done via "vendorizing" them by keeping a local copy (lowest initial maintenance impact) or switching to a build script for the front end (requires build step). Let me know if you want me to contribute something.