Fix #936

[VEZY]

Adding one more set of single quotes around the url seems to fix the issue. It feels a little hacky, but it's the only way I found to get around this. I tried using Cmd() with windows_verbatim = true too, but it didn't work either.

[VEZY]

Fix the issue #936, that is to say an issue when using Pluto.run with the notebook argument on windows.
Related to #862, which is closed and resolved but didn't work for me.

[fonsp]

Can you also try to open a notebook with a space in the filename? What about a full path, e.g. "C:\Users\fonsi\notebook.jl"?

[VEZY]

Can you also try to open a notebook with a space in the filename? What about a full path, e.g. "C:\Users\fonsi\notebook.jl"?

Yep good idea! I just tested a file with a space in the filename, a full path with \\, a full path with /, a relative path from a folder above the file, and a path with a folder with a space in it...

...and everything works ! 🎉

[fonsp]

Great, thanks!

Next we need to test on WSL1, WSL2 and maybe another Windows computer, i can do wsl2 and windows

[VEZY]

Great, thanks!

Next we need to test on WSL1, WSL2 and maybe another Windows computer, i can do wsl2 and windows

OK nice ! I just tested WSL1 with Ubuntu 20.04 and it works perfectly.

[VEZY]

Hello @fonsp, I had a little bit of time, so I tested on WSL 2 with Ubuntu 20.04 LTS, and it works. I guess that Github actions tests on windows-latest makes for the "another Windows computer" one ?

[stillyslalom]

Bumping this - it came up in r/Julia. Are there any blockers, or can this be merged?

[fonsp]

@pankgeorg or @ctrekker can you test this on windows?

[JakobAsslaender]

I tested it on a windows machine and it works like a charm! Thanks VEZY!

[fonsp]

Thanks for your patience!

[VEZY]

My pleasure, I'm sure you all have a lot of work and that was not a full priority because it worked anyway.