New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build error on the master branch #35

Open

GiggleLiu opened this issue Oct 20, 2020 · 0 comments

GiggleLiu commented Oct 20, 2020 •

edited

Loading

There is a large chunk of code in patch.jl copied from Pluto, which is hard to maintain. Now it error on the Pluto master branch.

IIUC, it basically added the following two lines.

    notebook_url = address * "edit?id=$(nb.notebook_id)"
    if session.options.server.launch_browser && open_in_default_browser(notebook_url)

Is there any reason for not PRing the patch into Pluto? @Roger-luo @fonsp

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment