Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for unshort #35

Closed
mauricedoepke opened this issue May 24, 2019 · 1 comment
Closed

Feature request for unshort #35

mauricedoepke opened this issue May 24, 2019 · 1 comment

Comments

@mauricedoepke
Copy link

I would expect the "unshort" function to also replace occurrences of "V" and "H" with L.
If this is not intended, a sperate function for this would be nice.

I would submit a PR for this if you'd accept it.

@puzrin
Copy link
Member

puzrin commented May 24, 2019

This function does exactly as it's designed for, and should not be changed. Also, i don't like to clutter API with trivial things.

@puzrin puzrin closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants