no more __stack, only one affine transform matrix is kept #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpym
force-pushed
the
transformsimplify
branch
6 times, most recently
from
3bb234c
to
5173b9c
Compare
kpym
force-pushed
the
transformsimplify
branch
from
5173b9c
to
29b4f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came to remove
__stackand replace it by a simple affine transform matrix.I know that you don't want to oversimplify your project, but as I came to do it for me I make a push request in case you decide one day to abandon the idea to stock all transforms separately in hope to make one day optimisations ...