clarify what input the package handles (issue #30) #31
Conversation
|
👌 Perhaps a link to https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths or some other source? |
README.md
Outdated
| @@ -6,11 +6,12 @@ svgpath | |||
| [](https://coveralls.io/r/fontello/svgpath?branch=master) | |||
|
|
|||
|
|
|||
| > Low level toolkit for SVG paths transformations. Sometime you can't use | |||
| `transform` attributes and have to apply changes to svg paths directly. | |||
| Low level toolkit for SVG paths transformations. | |||
There was a problem hiding this comment.
Please keep formatting. Return > to start of line
There was a problem hiding this comment.
Oh, yes, I forgot to mention that. With the >, that description becomes greyed out and it's a little hard to read (especially for what's supposed to be the main description of the repo). Perhaps some different formatting could be used, like italics?
|
@alexanderwallin good point. Linking to https://www.w3.org/TR/SVG11/paths.html#PathData may be more appropriate, agreed? |
|
No need to make things complex. Just modify example to use real string and show result. |
|
I would appreciate that link. |
|
I've restored the blockquote formatting, as requested. I also added the link to the docs -- I agree with @alexanderwallin that it is useful to end-users. |
|
Ok. Please, join all to single comit and i will merge it |
|
That can be done directly on github now :) just use the "Squash and merge" option, like this:
|
|
That leave garbage in comment lines. Could you join manually and force push? Text - something like "Clarify description in readme" |
|
Oh, so you tried it before? You might want to check it out again -- the functionality probably has been changed since you last used it, because now it does allow editing the full commit message (including the extended description) before merging, directly from the web interface. It's quite convenient, really :) But I can do it myself in the command line if you prefer. |
|
Seems to work. Thank you for info, now web squash is really useable. |
|
Yeah, they've been making several nice improvements to the UI recently, which makes both contribution and maintenance easier :) |
/cc @alexanderwallin