resovle ts error #57
Merged
resovle ts error #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Klaasvaak could you verify/confirm? |
|
@puzrin yes, my fault! The new typing is already an array so the [] have to be removed. |
|
Thank you for your help! I don't use TS, so trust your opinion. Could you check does master works now with real code? If no more problems, i will do release. |
|
@puzrin I can confirm using master makes |
|
Released 2.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://github.com/fontello/svgpath/blob/master/lib/svgpath.js#L387
the definition of
iterateseems to be wronghttps://github.com/fontello/svgpath/blob/master/index.d.ts#L43