Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Serif Height" in change weight dialog fixes the wrong nodes when thinning #3179

Open
Artoria2e5 opened this issue Oct 9, 2017 · 0 comments

Comments

@Artoria2e5
Copy link

Artoria2e5 commented Oct 9, 2017

I am running FontForge 2017-07-31 on Windows 10 (16299).

I used fontforge's change weight dialog to obtain a more hairline/contrast-rich thing from TeX Gyre Schola Bold 2.005 (sfnt 2.00499, texgyreschola-bold.zip). I selected some glyphs and opened the dialog, asking it to shrink the weight by 30 units.

As you can see in the screenshot below:

  • The serif height is correctly detected as 54 units
  • Due to the serif height setting, the node 54 units above the baseline is not moved.
  • Since fontforge is fixing the above nodes instead of the below nodes, the serif on the straight leg of R ends up moving up.

I expect fontforge to find some other nodes to fix when thinning fonts. For serifs at the bottom, that means the nodes near baseline level.

R, Before:
image

R, After:
image

Other letters show this problem as well.

More, before and after:
image
image

(I don't think it's quite visible from the screenshot; most of those serifs move up by 20-25 units from the baseline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant